[RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config

Subsystems: networking [general], rxrpc sockets (af_rxrpc), the rest

3 messages, 3 authors, 2021-02-13 · open the first message on its own page

[RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config

From: Vadim Fedorenko <hidden>
Date: 2021-02-12 10:49:11

As udp_port_cfg struct changes its members with dependency on IPv6
configuration, the code in rxrpc should also check for IPv6.

Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
Reported-by: kernel test robot <redacted>
Signed-off-by: Vadim Fedorenko <redacted>
---
 net/rxrpc/local_object.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c
index 546fd237a649..a4111408ffd0 100644
--- a/net/rxrpc/local_object.c
+++ b/net/rxrpc/local_object.c
@@ -120,9 +120,11 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
 	if (udp_conf.family == AF_INET) {
 		udp_conf.local_ip = srx->transport.sin.sin_addr;
 		udp_conf.local_udp_port = srx->transport.sin.sin_port;
+#if IS_ENABLED(CONFIG_AF_RXRPC_IPV6)
 	} else {
 		udp_conf.local_ip6 = srx->transport.sin6.sin6_addr;
 		udp_conf.local_udp_port = srx->transport.sin6.sin6_port;
+#endif
 	}
 	ret = udp_sock_create(net, &udp_conf, &local->socket);
 	if (ret < 0) {
-- 
2.18.4

Re: [RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config

From: David Howells <dhowells@redhat.com>
Date: 2021-02-12 17:22:09

Vadim Fedorenko [off-list ref] wrote:
As udp_port_cfg struct changes its members with dependency on IPv6
configuration, the code in rxrpc should also check for IPv6.

Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
Reported-by: kernel test robot <redacted>
Signed-off-by: Vadim Fedorenko <redacted>
Looks reasonable.

Acked-by: David Howells <dhowells@redhat.com>

Re: [RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-02-13 00:51:33

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 12 Feb 2021 13:48:14 +0300 you wrote:
As udp_port_cfg struct changes its members with dependency on IPv6
configuration, the code in rxrpc should also check for IPv6.

Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
Reported-by: kernel test robot <redacted>
Signed-off-by: Vadim Fedorenko <redacted>

[...]
Here is the summary with links:
  - [RESEND,net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config
    https://git.kernel.org/netdev/net-next/c/295f830e53f4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help