[PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

From: Corinna Vinschen <redacted>

commit 2643e6e90210e16c978919617170089b7c2164f7 upstream

TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP
every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000
secs on 80576 (45 bit SYSTIM).

This wrap event sets the TSICR.SysWrap bit unconditionally.

However, checking TSIM at interrupt time shows that this event does not
actually cause the interrupt.  Rather, it's just bycatch while the
actual interrupt is caused by, for instance, TSICR.TXTS.

The conclusion is that the SYS WRAP is actually expected, so the
"unexpected SYS WRAP" message is entirely bogus and just helps to
confuse users.  Drop it.

Signed-off-by: Corinna Vinschen <redacted>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Aaron Brown <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
Hi,

A customer reported that the following message appears in the kernel
logs every 1100s -

    igb 0000:01:00.1: unexpected SYS WRAP

As the systems have large uptimes the messages are crowding the logs.

The message was dropped in 
commit 2643e6e90210e16c ("igb: Remove incorrect "unexpected SYS WRAP" log message")
in v4.14.

Please consider applying to patch to v4.4 and v4.9 stable kernels - it
applies cleanly to both the trees.

Thanks,
Punit

 drivers/net/ethernet/intel/igb/igb_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index a4aa4d10ca70..682f52760898 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c

@@ -5421,8 +5421,6 @@ static void igb_tsync_interrupt(struct igb_adapter *adapter)
 		event.type = PTP_CLOCK_PPS;
 		if (adapter->ptp_caps.pps)
 			ptp_clock_event(adapter->ptp_clock, &event);
-		else
-			dev_err(&adapter->pdev->dev, "unexpected SYS WRAP");
 		ack |= TSINTR_SYS_WRAP;
 	}
 

-- 
2.29.2

-----Original Message-----
From: Punit Agrawal <redacted>
Sent: Tuesday, February 09, 2021 5:35 PM
To: netdev@vger.kernel.org
Cc: Brandeburg, Jesse <redacted>; Nguyen, Anthony L
[off-list ref]; daichi1.fukui@toshiba.co.jp;
nobuhiro1.iwamatsu@toshiba.co.jp; Corinna Vinschen [off-list ref];
Keller, Jacob E [off-list ref]; Brown, Aaron F
[off-list ref]; Jeff Kirsher [off-list ref]
Subject: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log
message

From: Corinna Vinschen <redacted>

commit 2643e6e90210e16c978919617170089b7c2164f7 upstream

TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP
every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000
secs on 80576 (45 bit SYSTIM).

This wrap event sets the TSICR.SysWrap bit unconditionally.

However, checking TSIM at interrupt time shows that this event does not
actually cause the interrupt.  Rather, it's just bycatch while the
actual interrupt is caused by, for instance, TSICR.TXTS.

The conclusion is that the SYS WRAP is actually expected, so the
"unexpected SYS WRAP" message is entirely bogus and just helps to
confuse users.  Drop it.

Signed-off-by: Corinna Vinschen <redacted>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Aaron Brown <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
Hi,

A customer reported that the following message appears in the kernel
logs every 1100s -

    igb 0000:01:00.1: unexpected SYS WRAP

As the systems have large uptimes the messages are crowding the logs.

The message was dropped in
commit 2643e6e90210e16c ("igb: Remove incorrect "unexpected SYS WRAP" log
message")
in v4.14.

Please consider applying to patch to v4.4 and v4.9 stable kernels - it
applies cleanly to both the trees.

Thanks,
Punit

It makes sense to me for htis to apply to those stable trees as well.

Thanks,
Jake

[
  * dropping Jeff Kirsher as his email is bouncing
  * Adding networking maintainers
]

"Keller, Jacob E" [off-list ref] writes:

quoted

-----Original Message-----
From: Punit Agrawal <redacted>
Sent: Tuesday, February 09, 2021 5:35 PM
To: netdev@vger.kernel.org
Cc: Brandeburg, Jesse <redacted>; Nguyen, Anthony L
[off-list ref]; daichi1.fukui@toshiba.co.jp;
nobuhiro1.iwamatsu@toshiba.co.jp; Corinna Vinschen [off-list ref];
Keller, Jacob E [off-list ref]; Brown, Aaron F
[off-list ref]; Jeff Kirsher [off-list ref]
Subject: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log
message

From: Corinna Vinschen <redacted>

commit 2643e6e90210e16c978919617170089b7c2164f7 upstream

TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP
every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000
secs on 80576 (45 bit SYSTIM).

This wrap event sets the TSICR.SysWrap bit unconditionally.

However, checking TSIM at interrupt time shows that this event does not
actually cause the interrupt.  Rather, it's just bycatch while the
actual interrupt is caused by, for instance, TSICR.TXTS.

The conclusion is that the SYS WRAP is actually expected, so the
"unexpected SYS WRAP" message is entirely bogus and just helps to
confuse users.  Drop it.

Signed-off-by: Corinna Vinschen <redacted>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Aaron Brown <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
Hi,

A customer reported that the following message appears in the kernel
logs every 1100s -

    igb 0000:01:00.1: unexpected SYS WRAP

As the systems have large uptimes the messages are crowding the logs.

The message was dropped in
commit 2643e6e90210e16c ("igb: Remove incorrect "unexpected SYS WRAP" log
message")
in v4.14.

Please consider applying to patch to v4.4 and v4.9 stable kernels - it
applies cleanly to both the trees.

Thanks,
Punit

It makes sense to me for htis to apply to those stable trees as well.

Thanks Jake.

Networking maintainers - It's been a couple of weeks this patch is on
the list. Is there anything else that needs to be done for it to be
picked up for stable?

Thanks,
Punit