[PATCH iproute2-next] ip route: Print "rt_offload_failed" indication

Subsystems: the rest

STALE2024d REVIEWED: 3 (3M)

1 review trailer.

2 messages, 2 authors, 2021-02-14 · open the first message on its own page

[PATCH iproute2-next] ip route: Print "rt_offload_failed" indication

From: Amit Cohen <hidden>
Date: 2021-02-09 09:17:41

The kernel signals when offload fails using the 'RTM_F_OFFLOAD_FAILED'
flag. Print it to help users understand the offload state of the route.
The "rt_" prefix is used in order to distinguish it from the offload state
of nexthops, similar to "rt_offload" and "rt_trap".

Signed-off-by: Amit Cohen <redacted>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
---
 ip/iproute.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/ip/iproute.c b/ip/iproute.c
index ebb5f160..a8c4886b 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -374,6 +374,8 @@ void print_rt_flags(FILE *fp, unsigned int flags)
 		print_string(PRINT_ANY, NULL, "%s ", "rt_offload");
 	if (flags & RTM_F_TRAP)
 		print_string(PRINT_ANY, NULL, "%s ", "rt_trap");
+	if (flags & RTM_F_OFFLOAD_FAILED)
+		print_string(PRINT_ANY, NULL, "%s ", "rt_offload_failed");
 
 	close_json_array(PRINT_JSON, NULL);
 }
-- 
2.26.2

Re: [PATCH iproute2-next] ip route: Print "rt_offload_failed" indication

From: David Ahern <hidden>
Date: 2021-02-14 00:52:27

On 2/9/21 2:12 AM, Amit Cohen wrote:
The kernel signals when offload fails using the 'RTM_F_OFFLOAD_FAILED'
flag. Print it to help users understand the offload state of the route.
The "rt_" prefix is used in order to distinguish it from the offload state
of nexthops, similar to "rt_offload" and "rt_trap".

Signed-off-by: Amit Cohen <redacted>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
---
 ip/iproute.c | 2 ++
 1 file changed, 2 insertions(+)
applied to iproute2-next
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help