[PATCH] Bluetooth: drop HCI device reference before return

Subsystems: bluetooth subsystem, the rest

STALE2024d

2 messages, 2 authors, 2021-01-25 · open the first message on its own page

[PATCH] Bluetooth: drop HCI device reference before return

From: Pan Bian <hidden>
Date: 2021-01-21 13:15:18

Call hci_dev_put() to decrement reference count of HCI device hdev if
fails to duplicate memory.

Fixes: 0b26ab9dce74 ("Bluetooth: AMP: Handle Accept phylink command status evt")
Signed-off-by: Pan Bian <redacted>
---
 net/bluetooth/a2mp.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c
index da7fd7c8c2dc..5974fd828c35 100644
--- a/net/bluetooth/a2mp.c
+++ b/net/bluetooth/a2mp.c
@@ -512,6 +512,7 @@ static int a2mp_createphyslink_req(struct amp_mgr *mgr, struct sk_buff *skb,
 		assoc = kmemdup(req->amp_assoc, assoc_len, GFP_KERNEL);
 		if (!assoc) {
 			amp_ctrl_put(ctrl);
+			hci_dev_put(hdev);
 			return -ENOMEM;
 		}
 
-- 
2.17.1

Re: [PATCH] Bluetooth: drop HCI device reference before return

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2021-01-25 15:52:52

Hi Pan,
Call hci_dev_put() to decrement reference count of HCI device hdev if
fails to duplicate memory.

Fixes: 0b26ab9dce74 ("Bluetooth: AMP: Handle Accept phylink command status evt")
Signed-off-by: Pan Bian <redacted>
---
net/bluetooth/a2mp.c | 1 +
1 file changed, 1 insertion(+)
patch has been applied to bluetooth-next tree.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help