[PATCH net-next] net: core: use eth_type_vlan in tap_get_user_xdp

Subsystems: networking drivers, the rest, tun/tap driver

STALE2037d

2 messages, 2 authors, 2021-01-15 · open the first message on its own page

[PATCH net-next] net: core: use eth_type_vlan in tap_get_user_xdp

From: <hidden>
Date: 2021-01-14 07:45:48

From: Menglong Dong <redacted>

Replace the check for ETH_P_8021Q and ETH_P_8021AD in
tap_get_user_xdp with eth_type_vlan.

Signed-off-by: Menglong Dong <redacted>
---
 drivers/net/tap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/tap.c b/drivers/net/tap.c
index 3c652c8ac5ba..e007583b5bd1 100644
--- a/drivers/net/tap.c
+++ b/drivers/net/tap.c
@@ -1164,8 +1164,7 @@ static int tap_get_user_xdp(struct tap_queue *q, struct xdp_buff *xdp)
 	}
 
 	/* Move network header to the right position for VLAN tagged packets */
-	if ((skb->protocol == htons(ETH_P_8021Q) ||
-	     skb->protocol == htons(ETH_P_8021AD)) &&
+	if (eth_type_vlan(skb->protocol) &&
 	    __vlan_get_protocol(skb, skb->protocol, &depth) != 0)
 		skb_set_network_header(skb, depth);
 
-- 
2.25.1

Re: [PATCH net-next] net: core: use eth_type_vlan in tap_get_user_xdp

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-15 02:22:54

On Wed, 13 Jan 2021 23:44:36 -0800 menglong8.dong@gmail.com wrote:
From: Menglong Dong <redacted>

Replace the check for ETH_P_8021Q and ETH_P_8021AD in
tap_get_user_xdp with eth_type_vlan.

Signed-off-by: Menglong Dong <redacted>
Similarly to bridge, please convert all the instances in tap in one
patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help