[PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison

Subsystems: realtek wireless driver (rtlwifi family), the rest

STALE2025d

3 messages, 3 authors, 2021-01-25 · open the first message on its own page

[PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison

From: YANG LI <hidden>
Date: 2021-01-12 08:34:56

Fix the following coccicheck warning:
./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
WARNING: Comparison of 0/1 to bool variable

Reported-by: Abaci Robot <redacted>
Signed-off-by: YANG LI <redacted>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
index 372d6f8..1fb857c 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
@@ -3848,7 +3848,7 @@ static void _rtl8821ae_iqk_tx(struct ieee80211_hw *hw, enum radio_path path)
 			else
 				rtl_write_dword(rtlpriv, 0xc8c, 0x00163e96);
 
-			if (vdf_enable == 1) {
+			if (vdf_enable) {
 				rtl_dbg(rtlpriv, COMP_IQK, DBG_LOUD, "VDF_enable\n");
 				for (k = 0; k <= 2; k++) {
 					switch (k) {
-- 
1.8.3.1

Re: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison

From: Pkshih <pkshih@realtek.com>
Date: 2021-01-12 13:21:41

On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote:
Fix the following coccicheck warning:
./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
WARNING: Comparison of 0/1 to bool variable

Reported-by: Abaci Robot <redacted>
Signed-off-by: YANG LI <redacted>
I think your name of Signed-off-by should be "Yang Li".

And, the subject prefix "rtlwifi: " is preferred.

---
Ping-Ke

Re: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison

From: Kalle Valo <hidden>
Date: 2021-01-25 14:33:45

YANG LI [off-list ref] wrote:
Fix the following coccicheck warning:
./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
WARNING: Comparison of 0/1 to bool variable

Reported-by: Abaci Robot <redacted>
Signed-off-by: YANG LI <redacted>
Patchwork gives me this From field:

From: Jiapeng Zhong <redacted>

I guess you are sharing the same email address with multiple persons? And patchwork stored the first person using that address?

I recommend using individual addresses for each person submitting patches. I
cannot apply this.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1610440409-73330-1-git-send-email-abaci-bugfix@linux.alibaba.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help