[PATCH net-next] net: core: use eth_type_vlan in __netif_receive_skb_core

Subsystems: networking [general], the rest

STALE2069d LANDED

Landed in mainline as 324cefaf1c72 on 2021-01-14.

2 messages, 2 authors, 2021-01-14 · open the first message on its own page

[PATCH net-next] net: core: use eth_type_vlan in __netif_receive_skb_core

From: <hidden>
Date: 2021-01-11 10:43:55

From: Menglong Dong <redacted>

Replace the check for ETH_P_8021Q and ETH_P_8021AD in
__netif_receive_skb_core with eth_type_vlan.

Signed-off-by: Menglong Dong <redacted>
---
 net/core/dev.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index e4d77c8abe76..267c4a8daa55 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5151,8 +5151,7 @@ static int __netif_receive_skb_core(struct sk_buff **pskb, bool pfmemalloc,
 		skb_reset_mac_len(skb);
 	}
 
-	if (skb->protocol == cpu_to_be16(ETH_P_8021Q) ||
-	    skb->protocol == cpu_to_be16(ETH_P_8021AD)) {
+	if (eth_type_vlan(skb->protocol)) {
 		skb = skb_vlan_untag(skb);
 		if (unlikely(!skb))
 			goto out;
@@ -5236,8 +5235,7 @@ static int __netif_receive_skb_core(struct sk_buff **pskb, bool pfmemalloc,
 			 * find vlan device.
 			 */
 			skb->pkt_type = PACKET_OTHERHOST;
-		} else if (skb->protocol == cpu_to_be16(ETH_P_8021Q) ||
-			   skb->protocol == cpu_to_be16(ETH_P_8021AD)) {
+		} else if (eth_type_vlan(skb->protocol)) {
 			/* Outer header is 802.1P with vlan 0, inner header is
 			 * 802.1Q or 802.1AD and vlan_do_receive() above could
 			 * not find vlan dev for vlan id 0.
-- 
2.17.1

Re: [PATCH net-next] net: core: use eth_type_vlan in __netif_receive_skb_core

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-01-14 03:21:07

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 11 Jan 2021 02:42:21 -0800 you wrote:
From: Menglong Dong <redacted>

Replace the check for ETH_P_8021Q and ETH_P_8021AD in
__netif_receive_skb_core with eth_type_vlan.

Signed-off-by: Menglong Dong <redacted>

[...]
Here is the summary with links:
  - [net-next] net: core: use eth_type_vlan in __netif_receive_skb_core
    https://git.kernel.org/netdev/net-next/c/324cefaf1c72

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help