# RE: \[EXT\] \[PATCH\] scsi: qedf: style: Simplify bool comparison

- From: Saurav Kashyap \<skashyap@marvell.com\>
- Date: 2021-01-11 09:46:57 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/01/6229361
- Thread: https://ratatoskr.run/linux-scsi/2021/01/6229346/t.md

```text
Hi,
Thanks for a patch.

> -----Original Message-----
> From: YANG LI <redacted>
> Sent: Monday, January 11, 2021 2:59 PM
> To: <redacted>
> Cc: <redacted>; Saurav Kashyap <skashyap@marvell.com>;
> Javed Hasan [ref]; GR-QLogic-Storage-Upstream <GR-
> QLogic-Storage-Upstream@marvell.com>; linux@armlinux.org.uk; linux-
> scsi@vger.kernel.org; linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
> YANG LI [ref]
> Subject: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
> ./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool
> 
> Signed-off-by: YANG LI <redacted>
> Reported-by: Abaci Robot<redacted>
> ---
>  drivers/scsi/qedf/qedf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index 46d185c..cec27f2 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -3713,7 +3713,7 @@ static void __qedf_remove(struct pci_dev *pdev, int
> mode)
>  	else
>  		fc_fabric_logoff(qedf->lport);
> 
> -	if (qedf_wait_for_upload(qedf) == false)
> +	if (!qedf_wait_for_upload(qedf))
>  		QEDF_ERR(&qedf->dbg_ctx, "Could not upload all sessions.\n");
> 
>  #ifdef CONFIG_DEBUG_FS
> --
> 1.8.3.1

Acked-by: Saurav Kashyap <skashyap@marvell.com>

```