[PATCH] scsi: qedf: style: Simplify bool comparison

Subsystems: qlogic ql41xxx fcoe driver, scsi subsystem, the rest

STALE2042d LANDED

Landed in mainline as ac341c2d2f1f on 2021-01-13.

3 messages, 3 authors, 2021-01-15 · open the first message on its own page

[PATCH] scsi: qedf: style: Simplify bool comparison

From: YANG LI <hidden>
Date: 2021-01-11 09:30:22 

Fix the following coccicheck warning:
./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool

Signed-off-by: YANG LI <redacted>
Reported-by: Abaci Robot<redacted>
---
 drivers/scsi/qedf/qedf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 46d185c..cec27f2 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -3713,7 +3713,7 @@ static void __qedf_remove(struct pci_dev *pdev, int mode)
 	else
 		fc_fabric_logoff(qedf->lport);
 
-	if (qedf_wait_for_upload(qedf) == false)
+	if (!qedf_wait_for_upload(qedf))
 		QEDF_ERR(&qedf->dbg_ctx, "Could not upload all sessions.\n");
 
 #ifdef CONFIG_DEBUG_FS
-- 
1.8.3.1

RE: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison

From: Saurav Kashyap <skashyap@marvell.com>
Date: 2021-01-11 09:46:57 

Hi,
Thanks for a patch.
quoted hunk
-----Original Message-----
From: YANG LI <redacted>
Sent: Monday, January 11, 2021 2:59 PM
To: jejb@linux.ibm.com
Cc: martin.petersen@oracle.com; Saurav Kashyap <skashyap@marvell.com>;
Javed Hasan [off-list ref]; GR-QLogic-Storage-Upstream <GR-
QLogic-Storage-Upstream@marvell.com>; linux@armlinux.org.uk; linux-
scsi@vger.kernel.org; linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
YANG LI [off-list ref]
Subject: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison

External Email

----------------------------------------------------------------------
Fix the following coccicheck warning:
./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool

Signed-off-by: YANG LI <redacted>
Reported-by: Abaci Robot<redacted>
---
 drivers/scsi/qedf/qedf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 46d185c..cec27f2 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -3713,7 +3713,7 @@ static void __qedf_remove(struct pci_dev *pdev, int
mode)
 	else
 		fc_fabric_logoff(qedf->lport);

-	if (qedf_wait_for_upload(qedf) == false)
+	if (!qedf_wait_for_upload(qedf))
 		QEDF_ERR(&qedf->dbg_ctx, "Could not upload all sessions.\n");

 #ifdef CONFIG_DEBUG_FS
--
1.8.3.1
Acked-by: Saurav Kashyap <skashyap@marvell.com>

Re: [PATCH] scsi: qedf: style: Simplify bool comparison

From: "Martin K. Petersen" <martin.petersen@oracle.com>
Date: 2021-01-15 04:14:43 

On Mon, 11 Jan 2021 17:29:28 +0800, YANG LI wrote:

Fix the following coccicheck warning:
./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool
Applied to 5.12/scsi-queue, thanks!

[1/1] scsi: qedf: style: Simplify bool comparison
      https://git.kernel.org/mkp/scsi/c/ac341c2d2f1f

-- 
Martin K. Petersen	Oracle Linux Engineering
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help