[PATCH] hci: llc_shdlc: style: Simplify bool comparison

Subsystems: networking [general], nfc subsystem, the rest

STALE2036d LANDED

Landed in mainline as f50e2f9f7916 on 2021-01-13.

2 messages, 2 authors, 2021-01-13 · open the first message on its own page

[PATCH] hci: llc_shdlc: style: Simplify bool comparison

From: YANG LI <hidden>
Date: 2021-01-11 09:25:35

Fix the following coccicheck warning:
./net/nfc/hci/llc_shdlc.c:239:5-21: WARNING: Comparison to bool

Signed-off-by: YANG LI <redacted>
Reported-by: Abaci Robot<redacted>
---
 net/nfc/hci/llc_shdlc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci/llc_shdlc.c
index 0eb4ddc..c0c8fea 100644
--- a/net/nfc/hci/llc_shdlc.c
+++ b/net/nfc/hci/llc_shdlc.c
@@ -236,7 +236,7 @@ static void llc_shdlc_rcv_i_frame(struct llc_shdlc *shdlc,
 		goto exit;
 	}
 
-	if (shdlc->t1_active == false) {
+	if (!shdlc->t1_active) {
 		shdlc->t1_active = true;
 		mod_timer(&shdlc->t1_timer, jiffies +
 			  msecs_to_jiffies(SHDLC_T1_VALUE_MS(shdlc->w)));
-- 
1.8.3.1

Re: [PATCH] hci: llc_shdlc: style: Simplify bool comparison

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-01-13 04:31:06

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 11 Jan 2021 17:24:23 +0800 you wrote:
Fix the following coccicheck warning:
./net/nfc/hci/llc_shdlc.c:239:5-21: WARNING: Comparison to bool

Signed-off-by: YANG LI <redacted>
Reported-by: Abaci Robot<redacted>
---
 net/nfc/hci/llc_shdlc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
  - hci: llc_shdlc: style: Simplify bool comparison
    https://git.kernel.org/netdev/net-next/c/f50e2f9f7916

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help