[PATCH] rtw88: debug: style: Simplify bool comparison

Subsystems: realtek wireless driver (rtw88), the rest

STALE2043d

2 messages, 2 authors, 2021-01-12 · open the first message on its own page

[PATCH] rtw88: debug: style: Simplify bool comparison

From: YANG LI <hidden>
Date: 2021-01-11 09:23:17

Fix the following coccicheck warning:
 ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
Comparison of 0/1 to bool variable

Signed-off-by: YANG LI <redacted>
Reported-by: Abaci Robot<redacted>
---
 drivers/net/wireless/realtek/rtw88/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c
index 19fc2d8..948cb79 100644
--- a/drivers/net/wireless/realtek/rtw88/debug.c
+++ b/drivers/net/wireless/realtek/rtw88/debug.c
@@ -800,7 +800,7 @@ static ssize_t rtw_debugfs_set_coex_enable(struct file *filp,
 	}
 
 	mutex_lock(&rtwdev->mutex);
-	coex->manual_control = enable == 0;
+	coex->manual_control = !enable;
 	mutex_unlock(&rtwdev->mutex);
 
 	return count;
-- 
1.8.3.1

Re: [PATCH] rtw88: debug: style: Simplify bool comparison

From: Pkshih <pkshih@realtek.com>
Date: 2021-01-12 02:21:07

On Mon, 2021-01-11 at 09:22 +0000, YANG LI wrote:
Fix the following coccicheck warning:
 ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
Comparison of 0/1 to bool variable

Signed-off-by: YANG LI <redacted>
Reported-by: Abaci Robot<redacted>---
 drivers/net/wireless/realtek/rtw88/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
I think that "rtw88:" or "rtw88: debug:" as subject prefix is enough.
Others are good to me.

---
Ping-Ke
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help