[PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE

Subsystems: networking drivers, networking [dsa], the rest

STALE2049d LANDED

Landed in mainline as 3545454c7801 on 2021-01-08.

3 messages, 3 authors, 2021-01-08 · open the first message on its own page

[PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE

From: Aleksander Jan Bajkowski <hidden>
Date: 2021-01-07 20:01:12

Exclude RMII from modes that report 1 GbE support. Reduced MII supports
up to 100 MbE.

Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Aleksander Jan Bajkowski <redacted>
---
 drivers/net/dsa/lantiq_gswip.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 4b36d89bec06..662e68a0e7e6 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -1436,11 +1436,12 @@ static void gswip_phylink_validate(struct dsa_switch *ds, int port,
 	phylink_set(mask, Pause);
 	phylink_set(mask, Asym_Pause);
 
-	/* With the exclusion of MII and Reverse MII, we support Gigabit,
-	 * including Half duplex
+	/* With the exclusion of MII, Reverse MII and Reduced MII, we
+	 * support Gigabit, including Half duplex
 	 */
 	if (state->interface != PHY_INTERFACE_MODE_MII &&
-	    state->interface != PHY_INTERFACE_MODE_REVMII) {
+	    state->interface != PHY_INTERFACE_MODE_REVMII &&
+	    state->interface != PHY_INTERFACE_MODE_RMII) {
 		phylink_set(mask, 1000baseT_Full);
 		phylink_set(mask, 1000baseT_Half);
 	}
-- 
2.20.1

Re: [PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-01-07 20:01:12

On 1/7/21 11:58 AM, Aleksander Jan Bajkowski wrote:
Exclude RMII from modes that report 1 GbE support. Reduced MII supports
up to 100 MbE.

Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Aleksander Jan Bajkowski <redacted>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-08 03:03:34

On Thu, 7 Jan 2021 12:00:44 -0800 Florian Fainelli wrote:
On 1/7/21 11:58 AM, Aleksander Jan Bajkowski wrote:
quoted
Exclude RMII from modes that report 1 GbE support. Reduced MII supports
up to 100 MbE.

Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Please make sure that the hash is at least 12 chars in the future.
quoted
Signed-off-by: Aleksander Jan Bajkowski <redacted>  
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help