[PATCH net-next] net: phy: at803x: use phy_modify_mmd()

Subsystems: ethernet phy library, networking drivers, the rest

STALE2042d LANDED

Landed in mainline as a45c1c10ebf2 on 2021-01-12.

3 messages, 3 authors, 2021-01-12 · open the first message on its own page

[PATCH net-next] net: phy: at803x: use phy_modify_mmd()

From: Russell King <hidden>
Date: 2021-01-10 14:55:21

Convert at803x_clk_out_config() to use phy_modify_mmd().

Signed-off-by: Russell King <redacted>
---
 drivers/net/phy/at803x.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index d0b36fd6c265..9636edb8d618 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -529,19 +529,12 @@ static void at803x_remove(struct phy_device *phydev)
 static int at803x_clk_out_config(struct phy_device *phydev)
 {
 	struct at803x_priv *priv = phydev->priv;
-	int val;
 
 	if (!priv->clk_25m_mask)
 		return 0;
 
-	val = phy_read_mmd(phydev, MDIO_MMD_AN, AT803X_MMD7_CLK25M);
-	if (val < 0)
-		return val;
-
-	val &= ~priv->clk_25m_mask;
-	val |= priv->clk_25m_reg;
-
-	return phy_write_mmd(phydev, MDIO_MMD_AN, AT803X_MMD7_CLK25M, val);
+	return phy_modify_mmd(phydev, MDIO_MMD_AN, AT803X_MMD7_CLK25M,
+			      priv->clk_25m_mask, priv->clk_25m_reg);
 }
 
 static int at8031_pll_config(struct phy_device *phydev)
-- 
2.20.1

Re: [PATCH net-next] net: phy: at803x: use phy_modify_mmd()

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-01-10 16:52:18

On Sun, Jan 10, 2021 at 02:54:36PM +0000, Russell King wrote:
Convert at803x_clk_out_config() to use phy_modify_mmd().

Signed-off-by: Russell King <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next] net: phy: at803x: use phy_modify_mmd()

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-12 00:32:06

On Sun, 10 Jan 2021 17:51:30 +0100 Andrew Lunn wrote:
On Sun, Jan 10, 2021 at 02:54:36PM +0000, Russell King wrote:
quoted
Convert at803x_clk_out_config() to use phy_modify_mmd().

Signed-off-by: Russell King <redacted>  
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help