Landed in mainline as b7501b9f4674 on 2021-01-12.
4 messages, 2 authors, 2021-01-12 · open the first message on its own page
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2021-01-09 21:59:56
Small improvements to jumbo configuration.
Heiner Kallweit (2):
r8169: align RTL8168e jumbo pcie read request size with vendor driver
r8169: tweak max read request size for newer chips also in jumbo mtu
mode
drivers/net/ethernet/realtek/r8169_main.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
--
2.30.0
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2021-01-09 22:01:11
Align behavior with r8168 vendor driver and don't reduce max read request size for RTL8168e in jumbo mode. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 74c8248ba..8336f1434 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c@@ -2342,12 +2342,10 @@ static void rtl_jumbo_config(struct rtl8169_private *tp) r8168dp_hw_jumbo_disable(tp); break; case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_33: - if (jumbo) { - pcie_set_readrq(tp->pci_dev, 512); + if (jumbo) r8168e_hw_jumbo_enable(tp); - } else { + else r8168e_hw_jumbo_disable(tp); - } break; default: break;
--
2.30.0
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2021-01-09 22:02:17
So far we don't increase the max read request size if we switch to jumbo mode before bringing up the interface for the first time. Let's change this. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 8336f1434..6e4c60185 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c@@ -2315,13 +2315,14 @@ static void r8168b_1_hw_jumbo_disable(struct rtl8169_private *tp) static void rtl_jumbo_config(struct rtl8169_private *tp) { bool jumbo = tp->dev->mtu > ETH_DATA_LEN; + int readrq = 4096; rtl_unlock_config_regs(tp); switch (tp->mac_version) { case RTL_GIGA_MAC_VER_12: case RTL_GIGA_MAC_VER_17: if (jumbo) { - pcie_set_readrq(tp->pci_dev, 512); + readrq = 512; r8168b_1_hw_jumbo_enable(tp); } else { r8168b_1_hw_jumbo_disable(tp);
@@ -2329,7 +2330,7 @@ static void rtl_jumbo_config(struct rtl8169_private *tp) break; case RTL_GIGA_MAC_VER_18 ... RTL_GIGA_MAC_VER_26: if (jumbo) { - pcie_set_readrq(tp->pci_dev, 512); + readrq = 512; r8168c_hw_jumbo_enable(tp); } else { r8168c_hw_jumbo_disable(tp);
@@ -2352,8 +2353,8 @@ static void rtl_jumbo_config(struct rtl8169_private *tp) } rtl_lock_config_regs(tp); - if (!jumbo && pci_is_pcie(tp->pci_dev) && tp->supports_gmii) - pcie_set_readrq(tp->pci_dev, 4096); + if (pci_is_pcie(tp->pci_dev) && tp->supports_gmii) + pcie_set_readrq(tp->pci_dev, readrq); } DECLARE_RTL_COND(rtl_chipcmd_cond)
--
2.30.0
From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-01-12 01:01:06
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 9 Jan 2021 22:59:08 +0100 you wrote:
Small improvements to jumbo configuration.
Heiner Kallweit (2):
r8169: align RTL8168e jumbo pcie read request size with vendor driver
r8169: tweak max read request size for newer chips also in jumbo mtu
mode
[...]
Here is the summary with links:
- [net-next,1/2] r8169: align RTL8168e jumbo pcie read request size with vendor driver
https://git.kernel.org/netdev/net-next/c/2007317e15cd
- [net-next,2/2] r8169: tweak max read request size for newer chips also in jumbo mtu mode
https://git.kernel.org/netdev/net-next/c/5e00e16cb989
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html