[PATCH net v2] docs: net: fix documentation on .ndo_get_stats
Subsystems:
documentation, networking [general], the rest
STALE2044d
3 messages,
3 authors,
2021-01-06 · open the first message on its own page
Fix calling context.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Documentation/networking/netdevices.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst
index 5a85fcc80c76..e65665c5ab50 100644
--- a/Documentation/networking/netdevices.rst
+++ b/Documentation/networking/netdevices.rst
@@ -64,8 +64,8 @@ struct net_device synchronization rules
Context: process
ndo_get_stats:
- Synchronization: dev_base_lock rwlock.
- Context: nominally process, but don't sleep inside an rwlock
+ Synchronization: rtnl_lock() semaphore, dev_base_lock rwlock, or RCU.
+ Context: atomic (can't sleep under rwlock or RCU)
ndo_start_xmit:
Synchronization: __netif_tx_lock spinlock.
--
2.26.2
On Mon, Jan 04, 2021 at 05:22:24PM -0800, Jakub Kicinski wrote:
quoted hunk
Fix calling context.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Documentation/networking/netdevices.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst
index 5a85fcc80c76..e65665c5ab50 100644
--- a/Documentation/networking/netdevices.rst
+++ b/Documentation/networking/netdevices.rst
@@ -64,8 +64,8 @@ struct net_device synchronization rules
Context: process
ndo_get_stats:
- Synchronization: dev_base_lock rwlock.
- Context: nominally process, but don't sleep inside an rwlock
+ Synchronization: rtnl_lock() semaphore, dev_base_lock rwlock, or RCU.
+ Context: atomic (can't sleep under rwlock or RCU)
ndo_start_xmit:
Synchronization: __netif_tx_lock spinlock.
--
2.26.2
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
From: Jakub Kicinski <kuba@kernel.org>
Date: Mon, 4 Jan 2021 17:22:24 -0800
Fix calling context.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Applied, thanks.