[PATCH net-next] net: marvell: prestera: simplify the return expression of prestera_port_close()

Subsystems: marvell prestera ethernet switch driver, networking drivers, the rest

STALE2099d

2 messages, 2 authors, 2020-12-10 · open the first message on its own page

[PATCH net-next] net: marvell: prestera: simplify the return expression of prestera_port_close()

From: Zheng Yongjun <hidden>
Date: 2020-12-09 09:18:41

Simplify the return expression.

Signed-off-by: Zheng Yongjun <redacted>
---
 drivers/net/ethernet/marvell/prestera/prestera_main.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 0f20e0788cce..13bd58dafc6c 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -93,15 +93,10 @@ static int prestera_port_open(struct net_device *dev)
 static int prestera_port_close(struct net_device *dev)
 {
 	struct prestera_port *port = netdev_priv(dev);
-	int err;
 
 	netif_stop_queue(dev);
 
-	err = prestera_hw_port_state_set(port, false);
-	if (err)
-		return err;
-
-	return 0;
+	return prestera_hw_port_state_set(port, false);
 }
 
 static netdev_tx_t prestera_port_xmit(struct sk_buff *skb,
-- 
2.22.0

Re: [PATCH net-next] net: marvell: prestera: simplify the return expression of prestera_port_close()

From: David Miller <davem@davemloft.net>
Date: 2020-12-10 01:12:16

From: Zheng Yongjun <redacted>
Date: Wed, 9 Dec 2020 17:17:51 +0800
Simplify the return expression.

Signed-off-by: Zheng Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help