Re: [PATCH net v2 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2020-12-16 14:18:30
Also in:
virtualization
On Wed, Dec 16, 2020 at 3:26 AM wangyunjian [off-list ref] wrote:
From: Yunjian Wang <redacted>
Currently the vhost_zerocopy_callback() maybe be called to decrease
the refcount when sendmsg fails in tun. The error handling in vhost
handle_tx_zerocopy() will try to decrease the same refcount again.
This is wrong. To fix this issue, we only call vhost_net_ubuf_put()
when vq->heads[nvq->desc].len == VHOST_DMA_IN_PROGRESS.
Fixes: 0690899b4d45 ("tun: experimental zero copy tx support")
Signed-off-by: Yunjian Wang <redacted>Acked-by: Willem de Bruijn <willemb@google.com> for next time: it's not customary to have an empty line between Fixes and Signed-off-by