Thread (27 messages) 27 messages, 6 authors, 2020-11-19

Re: [PATCH net-next] r8153_ecm: avoid to be prior to r8152 driver

From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-11-16 17:03:07
Also in: linux-usb, lkml

On Mon, 16 Nov 2020 10:18:13 +0100 Marek Szyprowski wrote:
On 16.11.2020 07:52, Hayes Wang wrote:
quoted
Avoid r8153_ecm is compiled as built-in, if r8152 driver is compiled
as modules. Otherwise, the r8153_ecm would be used, even though the
device is supported by r8152 driver.

Fixes: c1aedf015ebd ("net/usb/r8153_ecm: support ECM mode for RTL8153")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Hayes Wang <redacted>  
Yes, this fixes this issue, although I would prefer a separate Kconfig 
entry for r8153_ecm with proper dependencies instead of this ifdefs in 
Makefile.
Agreed, this is what dependency resolution is for.

Let's just make this a separate Kconfig entry.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help