Re: [PATCH net-next 10/13] octeontx2-pf: Add support for SR-IOV management functions

Hi Jakub,

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Monday, November 2, 2020 11:25 PM
To: Naveen Mamindlapalli <redacted>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
davem@davemloft.net; Sunil Kovvuri Goutham [off-list ref]; Linu
Cherian [off-list ref]; Geethasowjanya Akula
[off-list ref]; Jerin Jacob Kollanukkaran [off-list ref];
Subbaraya Sundeep Bhatta [off-list ref]; Hariprasad Kelam
[off-list ref]; Tomasz Duszynski [off-list ref]
Subject: Re: [PATCH net-next 10/13] octeontx2-pf: Add support for SR-IOV
management functions

On Mon, 2 Nov 2020 11:41:19 +0530 Naveen Mamindlapalli wrote:

quoted

This patch adds support for ndo_set_vf_mac, ndo_set_vf_vlan and
ndo_get_vf_config handlers. The traffic redirection based on the VF
mac address or vlan id is done by installing MCAM rules. Reserved
RX_VTAG_TYPE7 in each NIXLF for VF VLAN which strips the VLAN tag from
ingress VLAN traffic. The NIX PF allocates two MCAM entries for VF
VLAN feature, one used for ingress VTAG strip and another entry for
egress VTAG insertion.

This patch also updates the MAC address in PF installed VF VLAN rule
upon receiving nix_lf_start_rx mbox request for VF since
Administrative Function driver will assign a valid MAC addr in
nix_lf_start_rx function.

Signed-off-by: Naveen Mamindlapalli <redacted>
Co-developed-by: Tomasz Duszynski <redacted>
Signed-off-by: Tomasz Duszynski <redacted>
Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
Signed-off-by: Hariprasad Kelam <redacted>

drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast
to restricted __be16
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast
to restricted __be16
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast
to restricted __be16
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2097:31: warning: cast
to restricted __be16
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2158:55: warning:
incorrect type in argument 5 (different base types)
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2158:55:    expected
unsigned short [usertype] proto
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:2158:55:    got restricted
__be16 [usertype] proto
203a211,214
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c: In function
‘npc_update_dmac_value’:
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:1236:24: warning:
implicit conversion from ‘enum header_fields’ to ‘enum key_fields’ [-Wenum-
conversion]
 1236 |  npc_update_entry(rvu, NPC_DMAC, entry,
      |                        ^~~~~~~~

I will fix these warnings in v2.

Thanks,
Naveen