Re: [PATCH net-next 03/13] octeontx2-af: Generate key field bit mask from KEX profile

Hi Jakub,

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Monday, November 2, 2020 11:24 PM
To: Naveen Mamindlapalli <redacted>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
davem@davemloft.net; Sunil Kovvuri Goutham [off-list ref]; Linu
Cherian [off-list ref]; Geethasowjanya Akula
[off-list ref]; Jerin Jacob Kollanukkaran [off-list ref];
Subbaraya Sundeep Bhatta [off-list ref]; Hariprasad Kelam
[off-list ref]
Subject: Re: [PATCH net-next 03/13] octeontx2-af: Generate key field bit
mask from KEX profile

On Mon, 2 Nov 2020 11:41:12 +0530 Naveen Mamindlapalli wrote:

quoted

From: Subbaraya Sundeep <sbhatta@marvell.com>

Key Extraction(KEX) profile decides how the packet metadata such as
layer information and selected packet data bytes at each layer are
placed in MCAM search key. This patch reads the configured KEX profile
parameters to find out the bit position and bit mask for each field.
The information is used when programming the MCAM match data by SW to
match a packet flow and take appropriate action on the flow. This
patch also verifies the mandatory fields such as channel and DMAC are
not overwritten by the KEX configuration of other fields.

Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
Signed-off-by: Naveen Mamindlapalli <redacted>

Lots of new warnings like this here:

drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:351:38: warning:
implicit conversion from ‘enum header_fields’ to ‘enum key_fields’ [-Wenum-
conversion]
  351 |  if (npc_check_overlap(rvu, blkaddr, NPC_ETYPE, start_lid, intf))
      |                                      ^~~~~~~~~

I will fix these warnings in v2.

Thanks,
Naveen