[PATCH bpf-next] bpf: add struct bpf_redir_neigh forward declaration to BPF helper defs

Subsystems: the rest · Maintainer: Linus Torvalds

STALE2189d LANDED

Status: Landed in mainline as 821f5c90130d on 2020-10-29.

2 messages, 2 authors, 2020-10-29 · open the first message on its own page

[PATCH bpf-next] bpf: add struct bpf_redir_neigh forward declaration to BPF helper defs

From: Andrii Nakryiko <andrii@kernel.org>
Date: 2020-10-28 21:48:45

Forward-declare struct bpf_redir_neigh in bpf_helper_defs.h to avoid
compiler warning about unknown structs.

Fixes: ba452c9e996d ("bpf: Fix bpf_redirect_neigh helper api to support supplying nexthop")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
 scripts/bpf_helpers_doc.py | 1 +
 1 file changed, 1 insertion(+)
diff --git a/scripts/bpf_helpers_doc.py b/scripts/bpf_helpers_doc.py
index 6769caae142f..31484377b8b1 100755
--- a/scripts/bpf_helpers_doc.py
+++ b/scripts/bpf_helpers_doc.py
@@ -408,6 +408,7 @@ class PrinterHelpers(Printer):
             'struct bpf_perf_event_data',
             'struct bpf_perf_event_value',
             'struct bpf_pidns_info',
+            'struct bpf_redir_neigh',
             'struct bpf_sock',
             'struct bpf_sock_addr',
             'struct bpf_sock_ops',
-- 
2.24.1

Re: [PATCH bpf-next] bpf: add struct bpf_redir_neigh forward declaration to BPF helper defs

From: Toke Høiland-Jørgensen <hidden>
Date: 2020-10-29 00:32:43

Andrii Nakryiko [off-list ref] writes:
Forward-declare struct bpf_redir_neigh in bpf_helper_defs.h to avoid
compiler warning about unknown structs.

Fixes: ba452c9e996d ("bpf: Fix bpf_redirect_neigh helper api to support supplying nexthop")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Ah! I did actually include that in my local tree at some point, but
guess it never made it into the patch; sorry about that!

I guess this should go into the bpf tree, rather than bpf-next, no?

Acked-by: Toke Høiland-Jørgensen <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help