[PATCH bpf-next] xsk: remove internal DMA headers

Subsystems: networking [general], the rest, xdp sockets (af_xdp) · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds, Magnus Karlsson, Maciej Fijalkowski

STALE2216d LANDED

Status: Landed in mainline as b75597d8947f on 2020-10-05.

2 messages, 2 authors, 2020-10-05 · open the first message on its own page

[PATCH bpf-next] xsk: remove internal DMA headers

From: Björn Töpel <hidden>
Date: 2020-10-05 09:05:44

From: Björn Töpel <redacted>

Christoph Hellwig correctly pointed out [1] that the AF_XDP core was
pointlessly including internal headers. Let us remove those includes.

[1] https://lore.kernel.org/bpf/20201005084341.GA3224@infradead.org/

Reported-by: Christoph Hellwig <hch@infradead.org>
Fixes: 1c1efc2af158 ("xsk: Create and free buffer pool independently from umem")
Signed-off-by: Björn Töpel <redacted>
---
 net/xdp/xsk_buff_pool.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c
index e63fadd000db..64c9e55d4d4e 100644
--- a/net/xdp/xsk_buff_pool.c
+++ b/net/xdp/xsk_buff_pool.c
@@ -3,9 +3,6 @@
 #include <net/xsk_buff_pool.h>
 #include <net/xdp_sock.h>
 #include <net/xdp_sock_drv.h>
-#include <linux/dma-direct.h>
-#include <linux/dma-noncoherent.h>
-#include <linux/swiotlb.h>
 
 #include "xsk_queue.h"
 #include "xdp_umem.h"
base-commit: 1028ae4069991e26d1522e957939fb61d2da1d12
-- 
2.25.1

Re: [PATCH bpf-next] xsk: remove internal DMA headers

From: Christoph Hellwig <hch@infradead.org>
Date: 2020-10-05 09:06:11

On Mon, Oct 05, 2020 at 11:05:25AM +0200, Bj??rn T??pel wrote:
From: Bj??rn T??pel <redacted>

Christoph Hellwig correctly pointed out [1] that the AF_XDP core was
pointlessly including internal headers. Let us remove those includes.

[1] https://lore.kernel.org/bpf/20201005084341.GA3224@infradead.org/

Reported-by: Christoph Hellwig <hch@infradead.org>
Fixes: 1c1efc2af158 ("xsk: Create and free buffer pool independently from umem")
Signed-off-by: Bj??rn T??pel <redacted>
Thanks:

Acked-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help