# Re: \[PATCH RFC PKS/PMEM 24/58\] fs/freevxfs: Utilize new kmap\_thread()

- From: Christoph Hellwig \<hch@infradead.org\>
- Date: 2020-10-13 11:26:22 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/10/190532
- Thread: https://ratatoskr.run/linux-doc/2020/10/190353/t/2.md

```text
> -	kaddr = kmap(pp);
> +	kaddr = kmap_thread(pp);
>  	memcpy(kaddr, vip->vii_immed.vi_immed + offset, PAGE_SIZE);
> -	kunmap(pp);
> +	kunmap_thread(pp);

You only Cced me on this particular patch, which means I have absolutely
no idea what kmap_thread and kunmap_thread actually do, and thus can't
provide an informed review.

That being said I think your life would be a lot easier if you add
helpers for the above code sequence and its counterpart that copies
to a potential hughmem page first, as that hides the implementation
details from most users.
```
