# Re: \[trivial PATCH\] treewide: Convert switch/case fallthrough; to break;

- From: Jason Gunthorpe \<jgg@ziepe.ca\>
- Date: 2020-09-09 22:36:54 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/09/6099808
- Thread: https://ratatoskr.run/linux-arm-kernel/2020/09/6099701/t.md

```text
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote:
> fallthrough to a separate case/default label break; isn't very readable.
> 
> Convert pseudo-keyword fallthrough; statements to a simple break; when
> the next label is case or default and the only statement in the next
> label block is break;
> 
> Found using:
> 
> $ grep-2.5.4 -rP --include=*.[ch] -n "fallthrough;(\s*(case\s+\w+|default)\s*:\s*){1,7}break;" *
> 
> Miscellanea:
> 
> o Move or coalesce a couple label blocks above a default: block.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> 
> Compiled allyesconfig x86-64 only.
> A few files for other arches were not compiled.

IB part looks OK, I prefer it like this

You could do the same for continue as well, I saw a few of those..

Thanks,
Jason
```