[PATCH net-next] can: peak_canfd: Remove unused macros

Subsystems: can network drivers, the rest

STALE2147d LANDED

Landed in mainline as b060585d92cb on 2020-09-21.

2 messages, 2 authors, 2020-09-15 · open the first message on its own page

[PATCH net-next] can: peak_canfd: Remove unused macros

From: Wang Hai <hidden>
Date: 2020-09-04 13:15:40

CANFD_CLK_SEL_DIV_MASK and CANFD_OPTIONS_SET are
never used after they were introduced. Remove them.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
 drivers/net/can/peak_canfd/peak_pciefd_main.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/can/peak_canfd/peak_pciefd_main.c b/drivers/net/can/peak_canfd/peak_pciefd_main.c
index 9469d4421afe..5f0f39d2fa28 100644
--- a/drivers/net/can/peak_canfd/peak_pciefd_main.c
+++ b/drivers/net/can/peak_canfd/peak_pciefd_main.c
@@ -83,7 +83,6 @@ MODULE_LICENSE("GPL v2");
 #define CANFD_MISC_TS_RST		0x00000001	/* timestamp cnt rst */
 
 /* CAN-FD channel Clock SELector Source & DIVider */
-#define CANFD_CLK_SEL_DIV_MASK		0x00000007
 #define CANFD_CLK_SEL_DIV_60MHZ		0x00000000	/* SRC=240MHz only */
 #define CANFD_CLK_SEL_DIV_40MHZ		0x00000001	/* SRC=240MHz only */
 #define CANFD_CLK_SEL_DIV_30MHZ		0x00000002	/* SRC=240MHz only */
@@ -116,8 +115,6 @@ MODULE_LICENSE("GPL v2");
 #define CANFD_CTL_IRQ_CL_DEF	16	/* Rx msg max nb per IRQ in Rx DMA */
 #define CANFD_CTL_IRQ_TL_DEF	10	/* Time before IRQ if < CL (x100 µs) */
 
-#define CANFD_OPTIONS_SET	(CANFD_OPTION_ERROR | CANFD_OPTION_BUSLOAD)
-
 /* Tx anticipation window (link logical address should be aligned on 2K
  * boundary)
  */
-- 
2.17.1

Re: [PATCH net-next] can: peak_canfd: Remove unused macros

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2020-09-15 06:28:44

On 9/4/20 3:12 PM, Wang Hai wrote:
quoted hunk
CANFD_CLK_SEL_DIV_MASK and CANFD_OPTIONS_SET are
never used after they were introduced. Remove them.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
 drivers/net/can/peak_canfd/peak_pciefd_main.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/can/peak_canfd/peak_pciefd_main.c b/drivers/net/can/peak_canfd/peak_pciefd_main.c
index 9469d4421afe..5f0f39d2fa28 100644
--- a/drivers/net/can/peak_canfd/peak_pciefd_main.c
+++ b/drivers/net/can/peak_canfd/peak_pciefd_main.c
@@ -83,7 +83,6 @@ MODULE_LICENSE("GPL v2");
 #define CANFD_MISC_TS_RST		0x00000001	/* timestamp cnt rst */
 
 /* CAN-FD channel Clock SELector Source & DIVider */
-#define CANFD_CLK_SEL_DIV_MASK		0x00000007
I would like to keep this for documentation purpose.
quoted hunk
 #define CANFD_CLK_SEL_DIV_60MHZ		0x00000000	/* SRC=240MHz only */
 #define CANFD_CLK_SEL_DIV_40MHZ		0x00000001	/* SRC=240MHz only */
 #define CANFD_CLK_SEL_DIV_30MHZ		0x00000002	/* SRC=240MHz only */
@@ -116,8 +115,6 @@ MODULE_LICENSE("GPL v2");
 #define CANFD_CTL_IRQ_CL_DEF	16	/* Rx msg max nb per IRQ in Rx DMA */
 #define CANFD_CTL_IRQ_TL_DEF	10	/* Time before IRQ if < CL (x100 µs) */
 
-#define CANFD_OPTIONS_SET	(CANFD_OPTION_ERROR | CANFD_OPTION_BUSLOAD)
-
Okay, let's remove this.
 /* Tx anticipation window (link logical address should be aligned on 2K
  * boundary)
  */
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help