[PATCH] pktgen: fix error message with wrong function name

Subsystems: networking [general], the rest

STALE2162d

3 messages, 3 authors, 2020-09-01 · open the first message on its own page

[PATCH] pktgen: fix error message with wrong function name

From: Leesoo Ahn <hidden>
Date: 2020-09-01 13:17:52

Error on calling kthread_create_on_node prints wrong function name,
kernel_thread.

Signed-off-by: Leesoo Ahn <redacted>
---
 net/core/pktgen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 95f4c6b8f51a..44fdbb9c6e53 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3699,7 +3699,7 @@ static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn)
 				   cpu_to_node(cpu),
 				   "kpktgend_%d", cpu);
 	if (IS_ERR(p)) {
-		pr_err("kernel_thread() failed for cpu %d\n", t->cpu);
+		pr_err("kthread_create_on_node() failed for cpu %d\n", t->cpu);
 		list_del(&t->th_list);
 		kfree(t);
 		return PTR_ERR(p);
-- 
2.25.4

Re: [PATCH] pktgen: fix error message with wrong function name

From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Date: 2020-09-01 17:19:57

On Tue, Sep 01, 2020 at 10:04:47PM +0900, Leesoo Ahn wrote:
Error on calling kthread_create_on_node prints wrong function name,
kernel_thread.

Signed-off-by: Leesoo Ahn <redacted>
You might need to add the following tag:

Fixes: 94dcf29a11b3 ("kthread: use kthread_create_on_node()")

Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Thanks
--
Gustavo
quoted hunk
---
 net/core/pktgen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 95f4c6b8f51a..44fdbb9c6e53 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3699,7 +3699,7 @@ static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn)
 				   cpu_to_node(cpu),
 				   "kpktgend_%d", cpu);
 	if (IS_ERR(p)) {
-		pr_err("kernel_thread() failed for cpu %d\n", t->cpu);
+		pr_err("kthread_create_on_node() failed for cpu %d\n", t->cpu);
 		list_del(&t->th_list);
 		kfree(t);
 		return PTR_ERR(p);
-- 
2.25.4

Re: [PATCH] pktgen: fix error message with wrong function name

From: David Miller <davem@davemloft.net>
Date: 2020-09-01 18:45:18

From: Leesoo Ahn <redacted>
Date: Tue,  1 Sep 2020 22:04:47 +0900
Error on calling kthread_create_on_node prints wrong function name,
kernel_thread.

Signed-off-by: Leesoo Ahn <redacted>
Applied with Fixes: tag added.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help