On Wed, 30 Sep 2020 09:09:57 -0700 David Awogbemila wrote:

quoted

quoted

+             len -= hlen;
+             addr += hlen;
+             seg_desc = &tx->desc[(tx->req + 1) & tx->mask];
+             seg_idx_bias = 2;
+             gve_tx_fill_seg_desc(seg_desc, skb, is_gso, len, addr);
+     } else {
+             seg_idx_bias = 1;
+             gve_tx_fill_pkt_desc(pkt_desc, skb, is_gso, l4_hdr_offset,
+                                  1 + payload_nfrags, hlen, addr);  

and this look identical. You can probably move it before the if.  

Thanks, I need to make sure I understand: you're referring to the call
to gve_tx_fill_pkt_desc? if so, the calls look the same but
payload_nfrags is different in the if and else cases, perhaps I could
move it after the else? but I'm not sure if that helps.

Fair, you can leave it as is.