[PATCH bpf] bpf: add missing return to resolve_btfids

Subsystems: bpf [general] (safe dynamic programs and tools), the rest

STALE2216d LANDED

Landed in mainline as d48556f45608 on 2020-08-06.

3 messages, 2 authors, 2020-08-06 · open the first message on its own page

[PATCH bpf] bpf: add missing return to resolve_btfids

From: Stanislav Fomichev <hidden>
Date: 2020-08-06 17:07:03

int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.

Signed-off-by: Stanislav Fomichev <redacted>
---
 tools/bpf/resolve_btfids/main.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
index 52d883325a23..4d9ecb975862 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
 
 		next = rb_next(next);
 	}
+	return 0;
 }
 
 static int symbols_patch(struct object *obj)
-- 
2.28.0.236.gb10cc79966-goog

Re: [PATCH bpf] bpf: add missing return to resolve_btfids

From: <hidden>
Date: 2020-08-06 18:42:35

On 08/06, Stanislav Fomichev wrote:
int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.
Signed-off-by: Stanislav Fomichev <redacted>
---
  tools/bpf/resolve_btfids/main.c | 1 +
  1 file changed, 1 insertion(+)
quoted hunk
diff --git a/tools/bpf/resolve_btfids/main.c  
b/tools/bpf/resolve_btfids/main.c
index 52d883325a23..4d9ecb975862 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
  		next = rb_next(next);
  	}
+	return 0;
  }
  static int symbols_patch(struct object *obj)
--
2.28.0.236.gb10cc79966-goog
Sorry, forgot:

Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in  
ELF object")

Re: [PATCH bpf] bpf: add missing return to resolve_btfids

From: Alexei Starovoitov <hidden>
Date: 2020-08-06 23:52:33

On Thu, Aug 6, 2020 at 11:22 AM [off-list ref] wrote:
On 08/06, Stanislav Fomichev wrote:
quoted
int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.
quoted
Signed-off-by: Stanislav Fomichev <redacted>
---
  tools/bpf/resolve_btfids/main.c | 1 +
  1 file changed, 1 insertion(+)
quoted
diff --git a/tools/bpf/resolve_btfids/main.c
b/tools/bpf/resolve_btfids/main.c
index 52d883325a23..4d9ecb975862 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
quoted
              next = rb_next(next);
      }
+     return 0;
  }
quoted
  static int symbols_patch(struct object *obj)
--
2.28.0.236.gb10cc79966-goog
Sorry, forgot:

Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in
ELF object")
Applied. Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help