[PATCH v2 net-next] vmxnet3: use correct tcp hdr length when packet is encapsulated

Subsystems: networking drivers, the rest, vmware vmxnet3 ethernet driver

STALE2204d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2020-08-10 · open the first message on its own page

[PATCH v2 net-next] vmxnet3: use correct tcp hdr length when packet is encapsulated

From: Ronak Doshi <hidden>
Date: 2020-08-10 16:56:03

Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload
support") added support for encapsulation offload. However, while
calculating tcp hdr length, it does not take into account if the
packet is encapsulated or not.

This patch fixes this issue by using correct reference for inner
tcp header.

Fixes: dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload support")
Signed-off-by: Ronak Doshi <redacted>
Acked-by: Guolin Yang <redacted>
---
Changes in v2:
 - Undo changes to driver version
 - Fixed commit message

 drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index ca395f9679d0..2818015324b8 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -886,7 +886,8 @@ vmxnet3_parse_hdr(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
 
 			switch (protocol) {
 			case IPPROTO_TCP:
-				ctx->l4_hdr_size = tcp_hdrlen(skb);
+				ctx->l4_hdr_size = skb->encapsulation ? inner_tcp_hdrlen(skb) :
+						   tcp_hdrlen(skb);
 				break;
 			case IPPROTO_UDP:
 				ctx->l4_hdr_size = sizeof(struct udphdr);
-- 
2.11.0

Re: [PATCH v2 net-next] vmxnet3: use correct tcp hdr length when packet is encapsulated

From: David Miller <davem@davemloft.net>
Date: 2020-08-10 19:30:35

From: Ronak Doshi <redacted>
Date: Mon, 10 Aug 2020 09:55:55 -0700
Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload
support") added support for encapsulation offload. However, while
calculating tcp hdr length, it does not take into account if the
packet is encapsulated or not.

This patch fixes this issue by using correct reference for inner
tcp header.

Fixes: dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload support")
Signed-off-by: Ronak Doshi <redacted>
Acked-by: Guolin Yang <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help