[PATCH bpf] bpf: doc: remove references to warning message when using bpf_trace_printk()

Subsystems: bpf [general] (safe dynamic programs and tools), documentation, the rest

STALE2222d LANDED

Landed in mainline as 7fb20f9e901e on 2020-08-07.

2 messages, 2 authors, 2020-08-07 · open the first message on its own page

[PATCH bpf] bpf: doc: remove references to warning message when using bpf_trace_printk()

From: Alan Maguire <hidden>
Date: 2020-08-07 11:51:47

The BPF helper bpf_trace_printk() no longer uses trace_printk();
it is now triggers a dedicated trace event.  Hence the described
warning is no longer present, so remove the discussion of it as
it may confuse people.

Fixes: ac5a72ea5c89 ("bpf: Use dedicated bpf_trace_printk event instead of trace_printk()")
Signed-off-by: Alan Maguire <redacted>
---
 Documentation/bpf/bpf_design_QA.rst | 11 -----------
 1 file changed, 11 deletions(-)
diff --git a/Documentation/bpf/bpf_design_QA.rst b/Documentation/bpf/bpf_design_QA.rst
index 12a246f..2df7b06 100644
--- a/Documentation/bpf/bpf_design_QA.rst
+++ b/Documentation/bpf/bpf_design_QA.rst
@@ -246,17 +246,6 @@ program is loaded the kernel will print warning message, so
 this helper is only useful for experiments and prototypes.
 Tracing BPF programs are root only.
 
-Q: bpf_trace_printk() helper warning
-------------------------------------
-Q: When bpf_trace_printk() helper is used the kernel prints nasty
-warning message. Why is that?
-
-A: This is done to nudge program authors into better interfaces when
-programs need to pass data to user space. Like bpf_perf_event_output()
-can be used to efficiently stream data via perf ring buffer.
-BPF maps can be used for asynchronous data sharing between kernel
-and user space. bpf_trace_printk() should only be used for debugging.
-
 Q: New functionality via kernel modules?
 ----------------------------------------
 Q: Can BPF functionality such as new program or map types, new
-- 
1.8.3.1

Re: [PATCH bpf] bpf: doc: remove references to warning message when using bpf_trace_printk()

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2020-08-07 17:02:12

On 8/7/20 1:50 PM, Alan Maguire wrote:
The BPF helper bpf_trace_printk() no longer uses trace_printk();
it is now triggers a dedicated trace event.  Hence the described
warning is no longer present, so remove the discussion of it as
it may confuse people.

Fixes: ac5a72ea5c89 ("bpf: Use dedicated bpf_trace_printk event instead of trace_printk()")
Signed-off-by: Alan Maguire <redacted>
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help