[PATCH] net: qede: use eth_zero_addr() to clear mac address

Subsystems: networking drivers, qlogic ql4xxx ethernet driver, the rest

STALE2257d

2 messages, 2 authors, 2020-08-03 · open the first message on its own page

[PATCH] net: qede: use eth_zero_addr() to clear mac address

From: linmiaohe <linmiaohe@huawei.com>
Date: 2020-08-01 09:11:42

From: Miaohe Lin <linmiaohe@huawei.com>

Use eth_zero_addr() to clear mac address instead of memset().

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 drivers/net/ethernet/qlogic/qede/qede_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 29e285430f99..e1617a67a714 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -2678,8 +2678,8 @@ static void qede_get_generic_tlv_data(void *dev, struct qed_generic_tlvs *data)
 		data->feat_flags |= QED_TLV_LSO;
 
 	ether_addr_copy(data->mac[0], edev->ndev->dev_addr);
-	memset(data->mac[1], 0, ETH_ALEN);
-	memset(data->mac[2], 0, ETH_ALEN);
+	eth_zero_addr(data->mac[1]);
+	eth_zero_addr(data->mac[2]);
 	/* Copy the first two UC macs */
 	netif_addr_lock_bh(edev->ndev);
 	i = 1;
-- 
2.19.1

Re: [PATCH] net: qede: use eth_zero_addr() to clear mac address

From: David Miller <davem@davemloft.net>
Date: 2020-08-03 22:38:48

From: linmiaohe <linmiaohe@huawei.com>
Date: Sat, 1 Aug 2020 17:13:54 +0800
From: Miaohe Lin <linmiaohe@huawei.com>

Use eth_zero_addr() to clear mac address instead of memset().

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help