RE: [PATCH net-next] liquidio: Replace vmalloc with kmalloc in octeon_register_dispatch_fn()

From: Wang Hai <redacted>
Sent: Wednesday, July 29, 2020 11:12 PM
To: joe@perches.com; Derek Chickles <redacted>; Satananda
Burla [off-list ref]; Felix Manlunas [off-list ref];
davem@davemloft.net; kuba@kernel.org
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [EXT] [PATCH net-next] liquidio: Replace vmalloc with kmalloc in
octeon_register_dispatch_fn()

The size of struct octeon_dispatch is too small, it is better to use kmalloc
instead of vmalloc.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Wang Hai <redacted>
---
 drivers/net/ethernet/cavium/liquidio/octeon_device.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c

b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
index 934115d18488..ac32facaa427 100644

--- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c

@@ -1056,7 +1056,7 @@ void octeon_delete_dispatch_list(struct

octeon_device *oct)

 	list_for_each_safe(temp, tmp2, &freelist) {
 		list_del(temp);
-		vfree(temp);
+		kfree(temp);
 	}
 }

@@ -1152,13 +1152,10 @@ octeon_register_dispatch_fn(struct

octeon_device *oct,

 		dev_dbg(&oct->pci_dev->dev,
 			"Adding opcode to dispatch list linked list\n");
-		dispatch = (struct octeon_dispatch *)
-			   vmalloc(sizeof(struct octeon_dispatch));
-		if (!dispatch) {
-			dev_err(&oct->pci_dev->dev,
-				"No memory to add dispatch function\n");
+		dispatch = kmalloc(sizeof(*dispatch), GFP_KERNEL);
+		if (!dispatch)
 			return 1;
-		}
+
 		dispatch->opcode = combined_opcode;
 		dispatch->dispatch_fn = fn;
 		dispatch->arg = fn_arg;
--
2.17.1