Re: [PATCH] ipv6: Fix nexthop reference count in ip6_route_info_create()

From: Markus Elfring <hidden>
Date: 2020-07-25 09:34:54
Also in: lkml

When ip6_route_info_create() returns, local variable "nh" becomes
invalid, so the refcount should be decreased to keep refcount balanced.
Can it be helpful to use the term “reference count” in consistent ways?

Fix this issue
How do you think about to replace this wording by the tag “Fixes”?

               by pulling up the error source routing handling when
nexthops can not be used with source routing.
Does the movement of an if statement according to the check of the
data structure member “rt->fib6_src.plen” in an if branch really help here?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help