# Re: \[PATCH v1 04/11\] ena\_netdev: use generic power management

- From: Vaibhav Gupta \<hidden\>
- Date: 2020-07-01 16:47:16 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/07/6022112
- Thread: https://ratatoskr.run/netdev/2020/07/6021742/t.md

```text
On Wed, 1 Jul 2020 at 21:28, Jakub Kicinski [ref] wrote:
>
> On Wed,  1 Jul 2020 18:29:31 +0530 Vaibhav Gupta wrote:
> > With legacy PM, drivers themselves were responsible for managing the
> > device's power states and takes care of register states.
> >
> > After upgrading to the generic structure, PCI core will take care of
> > required tasks and drivers should do only device-specific operations.
> >
> > Compile-tested only.
> >
> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
>
> This one produces a warning on a W=1 build:
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c:4464:26: warning: ‘ena_pm_ops’ defined but not used [-Wunused-const-variable=]
>   4464 | static SIMPLE_DEV_PM_OPS(ena_pm_ops, ena_suspend, ena_resume);
I forgot to bind it inside "static struct pci_driver ena_pci_driver" :
      .driver.pm = &ena_pm_ops,

I am sending v2 of this particular patch.

--Vaibhav Gupta
```
