[PATCH] net: sched: export __netdev_watchdog_up()

Subsystems: networking [general], tc subsystem, the rest

STALE2254d

2 messages, 2 authors, 2020-06-04 · open the first message on its own page

[PATCH] net: sched: export __netdev_watchdog_up()

From: Valentin Longchamp <hidden>
Date: 2020-06-03 21:15:54

Since the quiesce/activate rework, __netdev_watchdog_up() is directly
called in the ucc_geth driver.

Unfortunately, this function is not available for modules and thus
ucc_geth cannot be built as a module anymore. Fix it by exporting
__netdev_watchdog_up().

Since the commit introducing the regression was backported to stable
branches, this one should ideally be as well.

Fixes: 79dde73cf9bc ("net/ethernet/freescale: rework quiesce/activate for ucc_geth")
Cc: <redacted>
Signed-off-by: Valentin Longchamp <redacted>
---
 net/sched/sch_generic.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index 2efd5b61acef..f1816516f638 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -464,6 +464,7 @@ void __netdev_watchdog_up(struct net_device *dev)
 			dev_hold(dev);
 	}
 }
+EXPORT_SYMBOL(__netdev_watchdog_up);
 
 static void dev_watchdog_up(struct net_device *dev)
 {
-- 
2.25.1

Re: [PATCH] net: sched: export __netdev_watchdog_up()

From: David Miller <davem@davemloft.net>
Date: 2020-06-04 22:54:35

From: Valentin Longchamp <redacted>
Date: Wed,  3 Jun 2020 23:15:27 +0200
quoted hunk
@@ -464,6 +464,7 @@ void __netdev_watchdog_up(struct net_device *dev)
 			dev_hold(dev);
 	}
 }
+EXPORT_SYMBOL(__netdev_watchdog_up);
Please use EXPORT_SYMBOL_GPL(), thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help