[PATCH] net/9p: Fix sparse endian warning in trans_fd.c

Subsystems: 9p file system, the rest

STALE2243d

3 messages, 2 authors, 2020-06-18 · open the first message on its own page

[PATCH] net/9p: Fix sparse endian warning in trans_fd.c

From: Alexander Kapshuk <hidden>
Date: 2020-06-18 18:34:30

Address sparse endian warning:
net/9p/trans_fd.c:932:28: warning: incorrect type in assignment (different base types)
net/9p/trans_fd.c:932:28:    expected restricted __be32 [addressable] [assigned] [usertype] s_addr
net/9p/trans_fd.c:932:28:    got unsigned long

Signed-off-by: Alexander Kapshuk <redacted>
---
 net/9p/trans_fd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index 13cd683a658a..2581f5145a22 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -929,7 +929,7 @@ static int p9_bind_privport(struct socket *sock)

 	memset(&cl, 0, sizeof(cl));
 	cl.sin_family = AF_INET;
-	cl.sin_addr.s_addr = INADDR_ANY;
+	cl.sin_addr.s_addr = htonl(INADDR_ANY);
 	for (port = p9_ipport_resv_max; port >= p9_ipport_resv_min; port--) {
 		cl.sin_port = htons((ushort)port);
 		err = kernel_bind(sock, (struct sockaddr *)&cl, sizeof(cl));
--
2.27.0

Re: [PATCH] net/9p: Fix sparse endian warning in trans_fd.c

From: Dominique Martinet <asmadeus@codewreck.org>
Date: 2020-06-18 19:09:53

Alexander Kapshuk wrote on Thu, Jun 18, 2020:
Address sparse endian warning:
net/9p/trans_fd.c:932:28: warning: incorrect type in assignment (different base types)
net/9p/trans_fd.c:932:28:    expected restricted __be32 [addressable] [assigned] [usertype] s_addr
net/9p/trans_fd.c:932:28:    got unsigned long

Signed-off-by: Alexander Kapshuk <redacted>
INADDR_ANY is 0 so this really is noop but sure, less warnings is always
good. I'll take this one for 5.9.
Thanks!
-- 
Dominique

Re: [PATCH] net/9p: Fix sparse endian warning in trans_fd.c

From: Alexander Kapshuk <hidden>
Date: 2020-06-18 19:28:13

On Thu, Jun 18, 2020 at 10:09 PM Dominique Martinet
[off-list ref] wrote:
Alexander Kapshuk wrote on Thu, Jun 18, 2020:
quoted
Address sparse endian warning:
net/9p/trans_fd.c:932:28: warning: incorrect type in assignment (different base types)
net/9p/trans_fd.c:932:28:    expected restricted __be32 [addressable] [assigned] [usertype] s_addr
net/9p/trans_fd.c:932:28:    got unsigned long

Signed-off-by: Alexander Kapshuk <redacted>
INADDR_ANY is 0 so this really is noop but sure, less warnings is always
good. I'll take this one for 5.9.
Thanks!
--
Dominique
Noted.
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help