# Re: \[PATCH 01/10\] x86/mm/numa: Remove uninitialized\_var() usage

- From: Thomas Gleixner \<hidden\>
- Date: 2020-06-04 21:39:20 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/06/5989878
- Thread: https://ratatoskr.run/linux-block/2020/06/5988825/t.md

```text
Kees Cook [ref] writes:
>> > -#define NODE_NOT_IN_PAGE_FLAGS
>> > +#define NODE_NOT_IN_PAGE_FLAGS 1
>> 
>> but if we ever lose the 1 then the above will silently compile the code
>> within the IS_ENABLED() section out.
>
> That's true, yes. I considered two other ways to do this:
>
> 1) smallest patch, but more #ifdef:
> 2) medium size, weird style:
>
> and 3 is what I sent: biggest, but removes #ifdef
>
> Any preference?

From a readbility POV I surely prefer #3. i"m just wary. Add a big fat
comment to the define might mitigate that, hmm?

Thanks,

        tglx
```