# Re: \[PATCH 00/10\] Remove uninitialized\_var() macro

- From: Kees Cook \<hidden\>
- Date: 2020-06-04 14:27:48 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/06/5989482
- Thread: https://ratatoskr.run/linux-block/2020/06/5988825/t.md

```text
On Thu, Jun 04, 2020 at 09:26:58AM +0200, Sedat Dilek wrote:
> On Thu, Jun 4, 2020 at 5:33 AM Nathan Chancellor
> [ref] wrote:
> >
> > On Wed, Jun 03, 2020 at 04:31:53PM -0700, Kees Cook wrote:
> > > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > > (or can in the future), and suppresses unrelated compiler warnings
> > > (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> > > either simply initialize the variable or make compiler changes.
> > >
> > > As recommended[2] by[3] Linus[4], remove the macro.
> > [...]
> > For the series, consider it:
> >
> > Tested-by: Nathan Chancellor <redacted> [build]
> [...]
> 
> I tried with updated version (checkpatch) of your tree and see no
> (new) warnings in my build-log.
> 
> Feel free to add my...
> 
> Tested-by: Sedat Dilek <redacted>

Awesome! Thank you both! :)

-- 
Kees Cook
```