# Re: \[PATCH 10/10\] compiler: Remove uninitialized\_var() macro

- From: Miguel Ojeda \<hidden\>
- Date: 2020-06-04 00:50:44 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/06/5988858
- Thread: https://ratatoskr.run/linux-block/2020/06/5988825/t.md

```text
Hi Kees,

On Thu, Jun 4, 2020 at 1:32 AM Kees Cook [ref] wrote:
>
> Using uninitialized_var() is dangerous as it papers over real bugs[1]
> (or can in the future), and suppresses unrelated compiler warnings
> (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> either simply initialize the variable or make compiler changes.
>
> As recommended[2] by[3] Linus[4], remove the macro.
>
> [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
> [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
> [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
> [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Kees Cook <redacted>
> ---

+1, one less trick split between `compiler*` files.

Reviewed-by: Miguel Ojeda <redacted>

Cheers,
Miguel
```