# Re: \[PATCH v2 1/2\] regmap: provide helpers for simple bit operations

- From: Mark Brown \<broonie@kernel.org\>
- Date: 2020-05-28 14:45:06 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/05/5982013
- Thread: https://ratatoskr.run/netdev/2020/05/5981981/t.md

```text
On Thu, May 28, 2020 at 04:22:40PM +0200, Bartosz Golaszewski wrote:

> +	return (val & bits) == bits ? 1 : 0;

The tenery here is redundant, it's converting a boolean value into a
boolean value.  Otherwise this looks good.
```

## Attachments

- [signature.asc](https://ratatoskr.run/netdev/2020/05/5982013/attachment/0) (application/pgp-signature, 488 bytes)
