# Re: \[PATCH 1/2\] regmap: provide helpers for simple bit operations

- From: Bartosz Golaszewski \<hidden\>
- Date: 2020-05-28 13:57:40 
- List: netdev
- Page: https://ratatoskr.run/netdev/2020/05/5981937
- Thread: https://ratatoskr.run/netdev/2020/05/5981798/t.md

```text
czw., 28 maj 2020 o 15:48 Mark Brown [ref] napisał(a):
>
> On Thu, May 28, 2020 at 03:32:40PM +0200, Bartosz Golaszewski wrote:
> > czw., 28 maj 2020 o 15:29 Mark Brown [ref] napisał(a):
>
> > > Why macros and not static inlines?
>
> > The existing regmap_update_bits_*() helpers are macros too, so I tried
> > to stay consistent. Any reason why they are macros and not static
> > inlines? If there's none, then why not convert them too? Otherwise
> > we'd have a static inline expanding a macro which in turn is calling a
> > function (regmap_update_bits_base()).
>
> Not really, I think it was just that they're argument tables.  It'd be
> good to convert them.

Ok. So I'm seeing there are a lot of macros in regmap.h that could
become static inlines but given the amount of regmap users: how about
we do it separately and in the meantime I'll just modify this series
to use static inlines?

Bartosz
```
