RE: Re: [v3,iproute2 1/2] iproute2:tc:action: add a gate control action

From: Po Liu <hidden>
Date: 2020-05-05 09:28:14
Also in: lkml

Hi Stephen,
-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org>
Sent: 2020年5月5日 8:07
To: Po Liu <redacted>
Cc: davem@davemloft.net; linux-kernel@vger.kernel.org;
netdev@vger.kernel.org; vinicius.gomes@intel.com; vlad@buslov.dev;
Claudiu Manoil [off-list ref]; Vladimir Oltean
[off-list ref]; Alexandru Marginean
[off-list ref]; michael.chan@broadcom.com;
vishal@chelsio.com; saeedm@mellanox.com; leon@kernel.org;
jiri@mellanox.com; idosch@mellanox.com;
alexandre.belloni@bootlin.com; UNGLinuxDriver@microchip.com;
kuba@kernel.org; xiyou.wangcong@gmail.com;
simon.horman@netronome.com; pablo@netfilter.org;
moshe@mellanox.com; m-karicheri2@ti.com;
andre.guedes@linux.intel.com
Subject: Re: [v3,iproute2 1/2] iproute2:tc:action: add a gate control
action

On Sun,  3 May 2020 14:32:50 +0800
Po Liu [off-list ref] wrote:
quoted
+             print_string(PRINT_ANY, "gate state", "\tgate-state %-8s",
NAK
Space in a json tag is not valid.

Please run a dump command and feed it into JSON validation checker like
Python.
I would test json format and upload new version  patch set.

Thanks!
Br,
Po Liu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help