RE: [PATCH V1 net-next 05/15] net: ena: add prints to failed commands

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Friday, May 22, 2020 1:00 AM
To: Kiyanovski, Arthur <akiyano@amazon.com>
Cc: davem@davemloft.net; netdev@vger.kernel.org; Woodhouse, David
[off-list ref]; Machulsky, Zorik [off-list ref];
Matushevsky, Alexander [off-list ref]; Bshara, Saeed
[off-list ref]; Wilson, Matt [off-list ref]; Liguori, Anthony
[off-list ref]; Bshara, Nafea [off-list ref]; Tzalik, Guy
[off-list ref]; Belgazal, Netanel [off-list ref]; Saidi, Ali
[off-list ref]; Herrenschmidt, Benjamin [off-list ref];
Dagan, Noam [off-list ref]; Agroskin, Shay
[off-list ref]; Jubran, Samih [off-list ref]
Subject: RE: [PATCH V1 net-next 05/15] net: ena: add prints to
failed commands
 


On Thu, 21 May 2020 22:08:24 +0300 akiyano@amazon.com wrote:

quoted

diff --git a/drivers/net/ethernet/amazon/ena/ena_eth_com.c

b/drivers/net/ethernet/amazon/ena/ena_eth_com.c
index a014f514c069..f0b90e1551a3 100644

--- a/drivers/net/ethernet/amazon/ena/ena_eth_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_eth_com.c

@@ -175,8 +175,10 @@ static int ena_com_close_bounce_buffer(struct

ena_com_io_sq *io_sq)

quoted

      if (pkt_ctrl->idx) {
              rc = ena_com_write_bounce_buffer_to_dev(io_sq,
                                                      pkt_ctrl->curr_bounce_buf);
-             if (unlikely(rc))
+             if (unlikely(rc)) {
+                     pr_err("failed to write bounce buffer to
+ device\n");

Could you use dev_err() or even better netdev_err() to give users an idea which
device is misbehaving?

quoted

                      return rc;
+             }

              pkt_ctrl->curr_bounce_buf =

ena_com_get_next_bounce_buffer(&io_sq->bounce_buf_ctrl);

Yes, you're right, that would be better.
I'll remove this patch from the patchset, rework it, and submit it again in a future patchset.
Thanks!