[PATCH] net: dsa: ksz: Select KSZ protocol tag

Subsystems: microchip ksz series ethernet switch driver, networking drivers, networking [dsa], the rest

STALE2331d REVIEWED: 1 (1M)

1 review trailer.

4 messages, 4 authors, 2020-03-31 · open the first message on its own page

[PATCH] net: dsa: ksz: Select KSZ protocol tag

From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Date: 2020-03-31 09:37:02

KSZ protocol tag is needed by the KSZ DSA drivers.

Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---

Patch was tested on a 9477-like switch, but the 8795 variant seems to be
in the same situation.
I am not very sure about the Fixes tag, but it seems to be the one since
it removes the dependency between old NET_DSA_TAG_KSZ9477 and
NET_DSA_TAG_KSZ.

 drivers/net/dsa/microchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/microchip/Kconfig b/drivers/net/dsa/microchip/Kconfig
index 1d7870c6df3c..4ec6a47b7f72 100644
--- a/drivers/net/dsa/microchip/Kconfig
+++ b/drivers/net/dsa/microchip/Kconfig
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config NET_DSA_MICROCHIP_KSZ_COMMON
+	select NET_DSA_TAG_KSZ
 	tristate
 
 menuconfig NET_DSA_MICROCHIP_KSZ9477
-- 
2.20.1

Re: [PATCH] net: dsa: ksz: Select KSZ protocol tag

From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-03-31 13:01:28

On Tue, Mar 31, 2020 at 12:36:51PM +0300, Codrin Ciubotariu wrote:
KSZ protocol tag is needed by the KSZ DSA drivers.

Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH] net: dsa: ksz: Select KSZ protocol tag

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2020-03-31 15:57:39


On 3/31/2020 2:36 AM, Codrin Ciubotariu wrote:
KSZ protocol tag is needed by the KSZ DSA drivers.

Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH] net: dsa: ksz: Select KSZ protocol tag

From: David Miller <davem@davemloft.net>
Date: 2020-03-31 17:05:01

From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Date: Tue, 31 Mar 2020 12:36:51 +0300
KSZ protocol tag is needed by the KSZ DSA drivers.

Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help