[PATCH 09/30] netrom: Add missing annotation for nr_info_stop()

Subsystems: networking [general], the rest

STALE2379d

Revision v1 of 2 in this series.

2 messages, 2 authors, 2020-02-24 · open the first message on its own page

[PATCH 09/30] netrom: Add missing annotation for nr_info_stop()

From: Jules Irenge <hidden>
Date: 2020-02-23 23:19:56

Sparse reports a warning at nr_info_stop()
warning: context imbalance in nr_info_stop() - unexpected unlock
The root cause is the missing annotation at nr_info_stop()
Add the missing __releases(&nr_list_lock)

Signed-off-by: Jules Irenge <redacted>
---
 net/netrom/af_netrom.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c
index 8be06e61ff03..7b1a74f74aad 100644
--- a/net/netrom/af_netrom.c
+++ b/net/netrom/af_netrom.c
@@ -1242,6 +1242,7 @@ static void *nr_info_next(struct seq_file *seq, void *v, loff_t *pos)
 }
 
 static void nr_info_stop(struct seq_file *seq, void *v)
+	__releases(&nr_list_lock)
 {
 	spin_unlock_bh(&nr_list_lock);
 }
-- 
2.24.1

Re: [PATCH 09/30] netrom: Add missing annotation for nr_info_stop()

From: David Miller <davem@davemloft.net>
Date: 2020-02-24 21:29:12

From: Jules Irenge <redacted>
Date: Sun, 23 Feb 2020 23:16:50 +0000
Sparse reports a warning at nr_info_stop()
warning: context imbalance in nr_info_stop() - unexpected unlock
The root cause is the missing annotation at nr_info_stop()
Add the missing __releases(&nr_list_lock)

Signed-off-by: Jules Irenge <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help