[PATCH 07/30] net: Add missing annotation for llc_seq_start()

Subsystems: llc (802.2), networking [general], the rest

STALE2380d

Revision v1 of 3 in this series.

2 messages, 2 authors, 2020-02-24 · open the first message on its own page

[PATCH 07/30] net: Add missing annotation for llc_seq_start()

From: Jules Irenge <hidden>
Date: 2020-02-23 23:19:50

Sparse reports a warning at llc_seq_start()

warning: context imbalance in llc_seq_start() - wrong count at exit
The root cause is the msiing annotation at llc_seq_start()

Add the missing __acquires(RCU) annotation

Signed-off-by: Jules Irenge <redacted>
---
 net/llc/llc_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/llc/llc_proc.c b/net/llc/llc_proc.c
index f3a36c16a5e7..a4eccb98220a 100644
--- a/net/llc/llc_proc.c
+++ b/net/llc/llc_proc.c
@@ -56,7 +56,7 @@ static struct sock *llc_get_sk_idx(loff_t pos)
 	return sk;
 }
 
-static void *llc_seq_start(struct seq_file *seq, loff_t *pos)
+static void *llc_seq_start(struct seq_file *seq, loff_t *pos) __acquires(RCU)
 {
 	loff_t l = *pos;
 
-- 
2.24.1

Re: [PATCH 07/30] net: Add missing annotation for llc_seq_start()

From: David Miller <davem@davemloft.net>
Date: 2020-02-24 21:29:04

From: Jules Irenge <redacted>
Date: Sun, 23 Feb 2020 23:16:48 +0000
Sparse reports a warning at llc_seq_start()

warning: context imbalance in llc_seq_start() - wrong count at exit
The root cause is the msiing annotation at llc_seq_start()

Add the missing __acquires(RCU) annotation

Signed-off-by: Jules Irenge <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help