[PATCH 10/30] net: netrom: Add missing annotation for nr_node_start()

Subsystems: networking [general], the rest

STALE2378d

2 messages, 2 authors, 2020-02-24 · open the first message on its own page

[PATCH 10/30] net: netrom: Add missing annotation for nr_node_start()

From: Jules Irenge <hidden>
Date: 2020-02-23 23:19:46

Sparse reports a warning at nr_node_start()
warning: context imbalance in nr_node_start() - wrong count at exit
The root cause is the missing annotation at nr_node_start()
Add the missing __acquires(&nr_node_list_lock) annotation

Signed-off-by: Jules Irenge <redacted>
---
 net/netrom/nr_route.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index d41335bad1f8..fe278fc24153 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -838,6 +838,7 @@ int nr_route_frame(struct sk_buff *skb, ax25_cb *ax25)
 #ifdef CONFIG_PROC_FS
 
 static void *nr_node_start(struct seq_file *seq, loff_t *pos)
+	__acquires(&nr_node_list_lock)
 {
 	spin_lock_bh(&nr_node_list_lock);
 	return seq_hlist_start_head(&nr_node_list, *pos);
-- 
2.24.1

Re: [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start()

From: David Miller <davem@davemloft.net>
Date: 2020-02-24 21:29:20

From: Jules Irenge <redacted>
Date: Sun, 23 Feb 2020 23:16:51 +0000
Sparse reports a warning at nr_node_start()
warning: context imbalance in nr_node_start() - wrong count at exit
The root cause is the missing annotation at nr_node_start()
Add the missing __acquires(&nr_node_list_lock) annotation

Signed-off-by: Jules Irenge <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help