[PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer()

Subsystems: networking [general], networking [unix sockets], the rest

STALE2382d

2 messages, 2 authors, 2020-02-24 · open the first message on its own page

[PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer()

From: Jules Irenge <hidden>
Date: 2020-02-23 23:18:21

Sparse reports a warning unix_wait_for_peer()

warning: context imbalance in unix_wait_for_peer() - unexpected unlock

The root cause is the missing annotation at unix_wait_for_peer()
Add the missing annotation __releases(&unix_sk(other)->lock)

Signed-off-by: Jules Irenge <redacted>
---
 net/unix/af_unix.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 62c12cb5763e..cbd7dc01e147 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -1207,6 +1207,7 @@ static int unix_dgram_connect(struct socket *sock, struct sockaddr *addr,
 }
 
 static long unix_wait_for_peer(struct sock *other, long timeo)
+	__releases(&unix_sk(other)->lock)
 {
 	struct unix_sock *u = unix_sk(other);
 	int sched;
-- 
2.24.1

Re: [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer()

From: David Miller <davem@davemloft.net>
Date: 2020-02-24 21:30:33

From: Jules Irenge <redacted>
Date: Sun, 23 Feb 2020 23:16:56 +0000
Sparse reports a warning unix_wait_for_peer()

warning: context imbalance in unix_wait_for_peer() - unexpected unlock

The root cause is the missing annotation at unix_wait_for_peer()
Add the missing annotation __releases(&unix_sk(other)->lock)

Signed-off-by: Jules Irenge <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help