[PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop()

Subsystems: networking [general], the rest

STALE2373d

2 messages, 2 authors, 2020-02-24 · open the first message on its own page

[PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop()

From: Jules Irenge <hidden>
Date: 2020-02-23 23:18:17

Sparse reports a warning at nr_neigh_stop()
warning: context imbalance in nr_neigh_stop() - unexpected unlock
The root cause is the missing annotation at nr_neigh_stop()
Add the missing __releases(&nr_neigh_list_lock) annotation

Signed-off-by: Jules Irenge <redacted>
---
 net/netrom/nr_route.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index 33e7b91fc805..79f12d8c7b86 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -907,6 +907,7 @@ static void *nr_neigh_next(struct seq_file *seq, void *v, loff_t *pos)
 }
 
 static void nr_neigh_stop(struct seq_file *seq, void *v)
+	__releases(&nr_neigh_list_lock)
 {
 	spin_unlock_bh(&nr_neigh_list_lock);
 }
-- 
2.24.1

Re: [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop()

From: David Miller <davem@davemloft.net>
Date: 2020-02-24 21:29:38

From: Jules Irenge <redacted>
Date: Sun, 23 Feb 2020 23:16:54 +0000
Sparse reports a warning at nr_neigh_stop()
warning: context imbalance in nr_neigh_stop() - unexpected unlock
The root cause is the missing annotation at nr_neigh_stop()
Add the missing __releases(&nr_neigh_list_lock) annotation

Signed-off-by: Jules Irenge <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help