[PATCH 04/30] sctp: Add missing annotation for sctp_err_finish()

Subsystems: networking [general], sctp protocol, the rest

STALE2390d

Revision v1 of 4 in this series.

2 messages, 2 authors, 2020-02-24 · open the first message on its own page

[PATCH 04/30] sctp: Add missing annotation for sctp_err_finish()

From: Jules Irenge <hidden>
Date: 2020-02-23 23:18:04

Sparse reports a warning at sctp_err_finish()
warning: context imbalance in sctp_err_finish() - unexpected unlock

The root cause is a missing annotation at sctp_err_finish()
Add the missing  __releases(&((__sk)->sk_lock.slock)) annotation

Signed-off-by: Jules Irenge <redacted>
---
 net/sctp/input.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/sctp/input.c b/net/sctp/input.c
index efaaefc3bb1c..55d4fc6f371d 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -548,6 +548,7 @@ struct sock *sctp_err_lookup(struct net *net, int family, struct sk_buff *skb,
 
 /* Common cleanup code for icmp/icmpv6 error handler. */
 void sctp_err_finish(struct sock *sk, struct sctp_transport *t)
+	__releases(&((__sk)->sk_lock.slock))
 {
 	bh_unlock_sock(sk);
 	sctp_transport_put(t);
-- 
2.24.1

Re: [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish()

From: David Miller <davem@davemloft.net>
Date: 2020-02-24 21:28:45

From: Jules Irenge <redacted>
Date: Sun, 23 Feb 2020 23:16:45 +0000
Sparse reports a warning at sctp_err_finish()
warning: context imbalance in sctp_err_finish() - unexpected unlock

The root cause is a missing annotation at sctp_err_finish()
Add the missing  __releases(&((__sk)->sk_lock.slock)) annotation

Signed-off-by: Jules Irenge <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help